X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fio.c;h=232b58d3358260dac0fec408a8cab85c14d0f25c;hb=56bb95c23210147d45b792e4e494e995d9de76dc;hp=3b8943c8dc31c1c00a0f0bc0b1705cb8f150f6e8;hpb=3928e14fbe1ed17cefe9bdbbb282fb7ecf053e7a;p=awesomized%2Flibmemcached diff --git a/libmemcached/io.c b/libmemcached/io.c index 3b8943c8..232b58d3 100644 --- a/libmemcached/io.c +++ b/libmemcached/io.c @@ -127,20 +127,21 @@ static bool process_input_buffer(memcached_server_instance_st *ptr) */ memcached_callback_st cb= *ptr->root->callbacks; - ptr->root->options.is_processing_input= true; + memcached_set_processing_input((memcached_st *)ptr->root, true); char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE]; memcached_return_t error; + memcached_st *root= (memcached_st *)ptr->root; error= memcached_response(ptr, buffer, sizeof(buffer), - &ptr->root->result); + &root->result); - ptr->root->options.is_processing_input = false; + memcached_set_processing_input(root, false); if (error == MEMCACHED_SUCCESS) { for (unsigned int x= 0; x < cb.number_of_callback; x++) { - error= (*cb.callback[x])(ptr->root, &ptr->root->result, cb.context); + error= (*cb.callback[x])(ptr->root, &root->result, cb.context); if (error != MEMCACHED_SUCCESS) break; } @@ -154,6 +155,42 @@ static bool process_input_buffer(memcached_server_instance_st *ptr) return false; } +static inline void memcached_io_cork_push(memcached_server_st *ptr) +{ +#ifdef CORK + if (ptr->root->flags.cork == false || ptr->state.is_corked) + return; + + int enable= 1; + int err= setsockopt(ptr->fd, IPPROTO_TCP, CORK, + &enable, (socklen_t)sizeof(int)); + if (! err) + ptr->state.is_corked= true; + + WATCHPOINT_ASSERT(ptr->state.is_corked == true); +#else + (void)ptr; +#endif +} + +static inline void memcached_io_cork_pop(memcached_server_st *ptr) +{ +#ifdef CORK + if (ptr->root->flags.cork == false || ptr->state.is_corked == false) + return; + + int enable= 0; + int err= setsockopt(ptr->fd, IPPROTO_TCP, CORK, + &enable, (socklen_t)sizeof(int)); + if (! err) + ptr->state.is_corked= false; + + WATCHPOINT_ASSERT(ptr->state.is_corked == false); +#else + (void)ptr; +#endif +} + #ifdef UNUSED void memcached_io_preread(memcached_st *ptr) { @@ -270,7 +307,7 @@ memcached_return_t memcached_io_read(memcached_server_instance_st *ptr, } ssize_t memcached_io_write(memcached_server_instance_st *ptr, - const void *buffer, size_t length, char with_flush) + const void *buffer, size_t length, bool with_flush) { size_t original_length; const char* buffer_ptr; @@ -280,6 +317,12 @@ ssize_t memcached_io_write(memcached_server_instance_st *ptr, original_length= length; buffer_ptr= buffer; + /* more writable data is coming if a flush isn't required, so delay send */ + if (! with_flush) + { + memcached_io_cork_push(ptr); + } + while (length) { char *write_ptr; @@ -330,7 +373,11 @@ ssize_t memcached_io_write(memcached_server_instance_st *ptr, memcached_return_t rc; WATCHPOINT_ASSERT(ptr->fd != -1); if (io_flush(ptr, &rc) == -1) + { return -1; + } + + memcached_io_cork_pop(ptr); } return (ssize_t) original_length;