X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Ffetch.cc;h=7ef608ddda231c9e9613b62187629aa4f6a4c949;hb=3bebb0839f95592b26678370969c474a88099c4c;hp=5a353d29e2fa19e72f2ff67c2ea6844fea799670;hpb=276e5c1e7fefa8f7061270f79443a704231c819e;p=awesomized%2Flibmemcached diff --git a/libmemcached/fetch.cc b/libmemcached/fetch.cc index 5a353d29..7ef608dd 100644 --- a/libmemcached/fetch.cc +++ b/libmemcached/fetch.cc @@ -115,19 +115,23 @@ char *memcached_fetch(memcached_st *ptr, char *key, size_t *key_length, if (flags) *flags= result_buffer->item_flags; - return memcached_string_c_copy(&result_buffer->value); + return memcached_string_take_value(&result_buffer->value); } memcached_result_st *memcached_fetch_result(memcached_st *ptr, memcached_result_st *result, memcached_return_t *error) { - memcached_server_st *server; - memcached_return_t unused; if (not error) error= &unused; + if (not ptr) + { + *error= MEMCACHED_INVALID_ARGUMENTS; + return NULL; + } + if (ptr->flags.use_udp) { *error= MEMCACHED_NOT_SUPPORTED; @@ -136,14 +140,24 @@ memcached_result_st *memcached_fetch_result(memcached_st *ptr, if (not result) { - if (not (result= memcached_result_create(ptr, NULL))) + // If we have already initialized (ie it is in use) our internal, we + // create one. + if (memcached_is_initialized(&ptr->result)) { - *error= MEMCACHED_MEMORY_ALLOCATION_FAILURE; - return NULL; + if (not (result= memcached_result_create(ptr, NULL))) + { + *error= MEMCACHED_MEMORY_ALLOCATION_FAILURE; + return NULL; + } + } + else + { + result= memcached_result_create(ptr, &ptr->result); } } *error= MEMCACHED_MAXIMUM_RETURN; // We use this to see if we ever go into the loop + memcached_server_st *server; while ((server= memcached_io_get_readable_server(ptr))) { char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];