X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Ffetch.c;h=4359c9355bf006af53a5b1e3d999fa2d263d3483;hb=f9f501287ffa6a2c69a9033536d3b6f14db34204;hp=7baac5449510a99b763e3fce4f9c0e8c0b7ebc90;hpb=7c7750f02368b570353ea109f23a0ea26d226e02;p=awesomized%2Flibmemcached diff --git a/libmemcached/fetch.c b/libmemcached/fetch.c index 7baac544..4359c935 100644 --- a/libmemcached/fetch.c +++ b/libmemcached/fetch.c @@ -26,14 +26,18 @@ char *memcached_fetch(memcached_st *ptr, char *key, size_t *key_length, if (key) { - strncpy(key, result_buffer->key, result_buffer->key_length); + if (result_buffer->key_length > MEMCACHED_MAX_KEY) + { + *error= MEMCACHED_KEY_TOO_BIG; + *value_length= 0; + + return NULL; + } + strncpy(key, result_buffer->item_key, result_buffer->key_length); // For the binary protocol we will cut off the key :( *key_length= result_buffer->key_length; } - if (result_buffer->flags) - *flags= result_buffer->flags; - else - *flags= 0; + *flags= result_buffer->item_flags; return memcached_string_c_copy(&result_buffer->value); } @@ -54,7 +58,7 @@ memcached_result_st *memcached_fetch_result(memcached_st *ptr, if ((result= memcached_result_create(ptr, NULL)) == NULL) return NULL; - while ((server = memcached_io_get_readable_server(ptr)) != NULL) + while ((server= memcached_io_get_readable_server(ptr)) != NULL) { char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE]; *error= memcached_response(server, buffer, sizeof(buffer), result);