X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fdelete.c;h=7fd1f2aa307c1837521fbb6b8fa41ad0b54fca42;hb=4eaa0bce7fc5f1d48662357d7237d103793783be;hp=3109c9e66677c45728df5d881c264c81582cbd65;hpb=9b767485048053ad0b4c2897a0d3784aa6e9fe10;p=awesomized%2Flibmemcached diff --git a/libmemcached/delete.c b/libmemcached/delete.c index 3109c9e6..7fd1f2aa 100644 --- a/libmemcached/delete.c +++ b/libmemcached/delete.c @@ -12,19 +12,19 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, uint32_t server_key, const char *key, size_t key_length, - uint8_t flush); + bool flush); memcached_return_t memcached_delete_by_key(memcached_st *ptr, const char *master_key, size_t master_key_length, const char *key, size_t key_length, time_t expiration) { - uint8_t to_write; + bool to_write; size_t send_length; memcached_return_t rc; char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE]; uint32_t server_key; - memcached_server_instance_st *instance; + memcached_server_write_instance_st instance; LIBMEMCACHED_MEMCACHED_DELETE_START(); @@ -36,10 +36,10 @@ memcached_return_t memcached_delete_by_key(memcached_st *ptr, unlikely (memcached_server_count(ptr) == 0) return MEMCACHED_NO_SERVERS; - server_key= memcached_generate_hash(ptr, master_key, master_key_length); + server_key= memcached_generate_hash_with_redistribution(ptr, master_key, master_key_length); instance= memcached_server_instance_fetch(ptr, server_key); - to_write= (uint8_t)((ptr->flags.buffer_requests) ? 0 : 1); + to_write= (ptr->flags.buffer_requests) ? false : true; bool no_reply= (ptr->flags.no_reply); @@ -77,13 +77,13 @@ memcached_return_t memcached_delete_by_key(memcached_st *ptr, if (instance->minor_version == 0) { - if (no_reply || !to_write) + if (no_reply || ! to_write) { /* We might get out of sync with the server if we * send this command to a server newer than 1.2.x.. * disable no_reply and buffered mode. */ - to_write= 1; + to_write= true; if (no_reply) memcached_server_response_increment(instance); no_reply= false; @@ -111,7 +111,7 @@ memcached_return_t memcached_delete_by_key(memcached_st *ptr, goto error; } - if (ptr->flags.use_udp && !to_write) + if (ptr->flags.use_udp && ! to_write) { if (send_length > MAX_UDP_DATAGRAM_LENGTH - UDP_DATAGRAM_HEADER_LENGTH) return MEMCACHED_WRITE_FAILURE; @@ -125,7 +125,7 @@ memcached_return_t memcached_delete_by_key(memcached_st *ptr, if (rc != MEMCACHED_SUCCESS) goto error; - if (!to_write) + if (! to_write) rc= MEMCACHED_BUFFERED; else if (!no_reply) { @@ -146,9 +146,9 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, uint32_t server_key, const char *key, size_t key_length, - uint8_t flush) + bool flush) { - memcached_server_instance_st *instance; + memcached_server_write_instance_st instance; protocol_binary_request_delete request= {.bytes= {0}}; instance= memcached_server_instance_fetch(ptr, server_key); @@ -162,7 +162,7 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, request.message.header.request.datatype= PROTOCOL_BINARY_RAW_BYTES; request.message.header.request.bodylen= htonl((uint32_t) key_length); - if (ptr->flags.use_udp && !flush) + if (ptr->flags.use_udp && ! flush) { size_t cmd_size= sizeof(request.bytes) + key_length; if (cmd_size > MAX_UDP_DATAGRAM_LENGTH - UDP_DATAGRAM_HEADER_LENGTH) @@ -174,9 +174,9 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, memcached_return_t rc= MEMCACHED_SUCCESS; if ((memcached_do(instance, request.bytes, - sizeof(request.bytes), 0) != MEMCACHED_SUCCESS) || + sizeof(request.bytes), false) != MEMCACHED_SUCCESS) || (memcached_io_write(instance, key, - key_length, (bool) flush) == -1)) + key_length, flush) == -1)) { memcached_io_reset(instance); rc= MEMCACHED_WRITE_FAILURE; @@ -188,7 +188,7 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, for (uint32_t x= 0; x < ptr->number_of_replicas; ++x) { - memcached_server_instance_st *replica; + memcached_server_write_instance_st replica; ++server_key; if (server_key == memcached_server_count(ptr)) @@ -197,8 +197,8 @@ static inline memcached_return_t binary_delete(memcached_st *ptr, replica= memcached_server_instance_fetch(ptr, server_key); if ((memcached_do(replica, (const char*)request.bytes, - sizeof(request.bytes), 0) != MEMCACHED_SUCCESS) || - (memcached_io_write(replica, key, key_length, (bool) flush) == -1)) + sizeof(request.bytes), false) != MEMCACHED_SUCCESS) || + (memcached_io_write(replica, key, key_length, flush) == -1)) { memcached_io_reset(replica); }