X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fcommon.h;h=b46d5ba06cd3a5c22fd2ef8bcc62a4f118723c0e;hb=a7a011c2ea4a63368b3a96a332da00820ed402cb;hp=d8371d18dfa69d89adbbd5561ea198472bdfd0ba;hpb=ba35cd77a343901f61e4fc5279328b571e51604e;p=m6w6%2Flibmemcached diff --git a/libmemcached/common.h b/libmemcached/common.h index d8371d18..b46d5ba0 100644 --- a/libmemcached/common.h +++ b/libmemcached/common.h @@ -48,6 +48,7 @@ #include "libmemcached/memcached_internal.h" #include "libmemcached/libmemcached_probes.h" #include "libmemcached/memcached/protocol_binary.h" +#include "libmemcached/byteorder.h" /* string value */ struct memcached_continuum_item_st { @@ -63,8 +64,8 @@ struct memcached_continuum_item_st { #else -#define likely(x) if(__builtin_expect(!!(x), 1)) -#define unlikely(x) if(__builtin_expect((x), 0)) +#define likely(x) if(__builtin_expect((x) != 0, 1)) +#define unlikely(x) if(__builtin_expect((x) != 0, 0)) #endif @@ -135,28 +136,22 @@ LIBMEMCACHED_LOCAL void server_list_free(memcached_st *ptr, memcached_server_st *servers); LIBMEMCACHED_LOCAL -memcached_return memcached_key_test(char **keys, size_t *key_length, - unsigned int number_of_keys); +memcached_return memcached_key_test(const char * const *keys, + const size_t *key_length, + size_t number_of_keys); LIBMEMCACHED_LOCAL uint32_t generate_hash(memcached_st *ptr, const char *key, size_t key_length); -#ifndef HAVE_HTONLL -LIBMEMCACHED_LOCAL -extern uint64_t ntohll(uint64_t); -LIBMEMCACHED_LOCAL -extern uint64_t htonll(uint64_t); -#endif - LIBMEMCACHED_LOCAL memcached_return memcached_purge(memcached_server_st *ptr); -static inline memcached_return memcached_validate_key_length(size_t key_length, +static inline memcached_return memcached_validate_key_length(size_t key_length, bool binary) { unlikely (key_length == 0) return MEMCACHED_BAD_KEY_PROVIDED; - + if (binary) { unlikely (key_length > 0xffff) @@ -164,7 +159,7 @@ static inline memcached_return memcached_validate_key_length(size_t key_length, } else { - unlikely (key_length >= MEMCACHED_MAX_KEY) + unlikely (key_length >= MEMCACHED_MAX_KEY) return MEMCACHED_BAD_KEY_PROVIDED; }