X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libmemcached%2Fauto.c;h=16e65b863a3ad85b4b987d8f596d0e2c3c4eeda4;hb=4767d70bea3e4930081016a15630ac927757962b;hp=ba7ea6d31dd4d59ea727a177a3e2efd72dc8f7a1;hpb=9b767485048053ad0b4c2897a0d3784aa6e9fe10;p=m6w6%2Flibmemcached diff --git a/libmemcached/auto.c b/libmemcached/auto.c index ba7ea6d3..16e65b86 100644 --- a/libmemcached/auto.c +++ b/libmemcached/auto.c @@ -22,7 +22,7 @@ static memcached_return_t text_incr_decr(memcached_st *ptr, memcached_return_t rc; char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE]; uint32_t server_key; - memcached_server_instance_st *instance; + memcached_server_write_instance_st instance; bool no_reply= ptr->flags.no_reply; unlikely (memcached_server_count(ptr) == 0) @@ -31,7 +31,7 @@ static memcached_return_t text_incr_decr(memcached_st *ptr, if (ptr->flags.verify_key && (memcached_key_test((const char **)&key, &key_length, 1) == MEMCACHED_BAD_KEY_PROVIDED)) return MEMCACHED_BAD_KEY_PROVIDED; - server_key= memcached_generate_hash(ptr, master_key, master_key_length); + server_key= memcached_generate_hash_with_redistribution(ptr, master_key, master_key_length); instance= memcached_server_instance_fetch(ptr, server_key); send_length= (size_t)snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, @@ -43,7 +43,7 @@ static memcached_return_t text_incr_decr(memcached_st *ptr, unlikely (send_length >= MEMCACHED_DEFAULT_COMMAND_SIZE) return MEMCACHED_WRITE_FAILURE; - rc= memcached_do(instance, buffer, send_length, 1); + rc= memcached_do(instance, buffer, send_length, true); if (no_reply || rc != MEMCACHED_SUCCESS) return rc; @@ -56,7 +56,12 @@ static memcached_return_t text_incr_decr(memcached_st *ptr, use it. We still called memcached_response() though since it worked its magic for non-blocking IO. */ - if (!strncmp(buffer, "ERROR\r\n", 7)) + if (! strncmp(buffer, "ERROR\r\n", 7)) + { + *value= 0; + rc= MEMCACHED_PROTOCOL_ERROR; + } + else if (! strncmp(buffer, "CLIENT_ERROR\r\n", 14)) { *value= 0; rc= MEMCACHED_PROTOCOL_ERROR; @@ -83,13 +88,13 @@ static memcached_return_t binary_incr_decr(memcached_st *ptr, uint8_t cmd, uint64_t *value) { uint32_t server_key; - memcached_server_instance_st *instance; + memcached_server_write_instance_st instance; bool no_reply= ptr->flags.no_reply; unlikely (memcached_server_count(ptr) == 0) return MEMCACHED_NO_SERVERS; - server_key= memcached_generate_hash(ptr, master_key, master_key_length); + server_key= memcached_generate_hash_with_redistribution(ptr, master_key, master_key_length); instance= memcached_server_instance_fetch(ptr, server_key); if (no_reply) @@ -103,20 +108,26 @@ static memcached_return_t binary_incr_decr(memcached_st *ptr, uint8_t cmd, request.message.header.request.magic= PROTOCOL_BINARY_REQ; request.message.header.request.opcode= cmd; - request.message.header.request.keylen= htons((uint16_t) key_length); + request.message.header.request.keylen= htons((uint16_t)(key_length + ptr->prefix_key_length)); request.message.header.request.extlen= 20; request.message.header.request.datatype= PROTOCOL_BINARY_RAW_BYTES; - request.message.header.request.bodylen= htonl((uint32_t) (key_length + request.message.header.request.extlen)); + request.message.header.request.bodylen= htonl((uint32_t)(key_length + ptr->prefix_key_length + request.message.header.request.extlen)); request.message.body.delta= htonll(offset); request.message.body.initial= htonll(initial); request.message.body.expiration= htonl((uint32_t) expiration); - if ((memcached_do(instance, request.bytes, - sizeof(request.bytes), 0)!=MEMCACHED_SUCCESS) || - (memcached_io_write(instance, key, key_length, true) == -1)) + struct __write_vector_st vector[]= + { + { .length= ptr->prefix_key_length, .buffer= ptr->prefix_key }, + { .length= key_length, .buffer= key } + }; + + memcached_return_t rc; + if (((rc= memcached_do(instance, request.bytes, sizeof(request.bytes), false)) != MEMCACHED_SUCCESS) || + (memcached_io_writev(instance, vector, 2, true) == -1)) { memcached_io_reset(instance); - return MEMCACHED_WRITE_FAILURE; + return (rc == MEMCACHED_SUCCESS) ? MEMCACHED_WRITE_FAILURE : rc; } if (no_reply)