X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=libhashkit%2Fhsieh.c;h=ba46ed2cdf71c3b59e1f43691703885722c7c4f5;hb=2230ba7b89bbaa989de311f9d7ea6d6e2cd5a9b8;hp=46cc241e330125249466b225e96976e817d634ad;hpb=ec35c1ba09b8eb49505d32d23a2b679be3c45add;p=m6w6%2Flibmemcached

diff --git a/libhashkit/hsieh.c b/libhashkit/hsieh.c
index 46cc241e..ba46ed2c 100644
--- a/libhashkit/hsieh.c
+++ b/libhashkit/hsieh.c
@@ -17,7 +17,7 @@
                       +(uint32_t)(((const uint8_t *)(d))[0]) )
 #endif
 
-uint32_t hashkit_hsieh(const char *key, size_t key_length, void *context__attribute__((unused)))
+uint32_t hashkit_hsieh(const char *key, size_t key_length, void *context __attribute__((unused)))
 {
   uint32_t hash = 0, tmp;
   int rem;
@@ -43,16 +43,18 @@ uint32_t hashkit_hsieh(const char *key, size_t key_length, void *context__attrib
   {
   case 3: hash += get16bits (key);
           hash ^= hash << 16;
-          hash ^= key[sizeof (uint16_t)] << 18;
+          hash ^= (uint32_t)key[sizeof (uint16_t)] << 18;
           hash += hash >> 11;
           break;
   case 2: hash += get16bits (key);
           hash ^= hash << 11;
           hash += hash >> 17;
           break;
-  case 1: hash += *key;
+  case 1: hash += (unsigned char)(*key);
           hash ^= hash << 10;
           hash += hash >> 1;
+  default:
+          break;
   }
 
   /* Force "avalanching" of final 127 bits */