X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=lib%2Fmemcached_storage.c;h=ba8835cb40ee223fac8c95e7d35bda6fb52e437e;hb=e1944ccd4d1e65f4192783fa9c564c9b747bb618;hp=7b48afeedea1e29a5b1146004ee73a59040324bc;hpb=264a1ae95d273b6b32afed45d7c7c7461bfa54e4;p=m6w6%2Flibmemcached diff --git a/lib/memcached_storage.c b/lib/memcached_storage.c index 7b48afee..ba8835cb 100644 --- a/lib/memcached_storage.c +++ b/lib/memcached_storage.c @@ -62,21 +62,10 @@ static inline memcached_return memcached_send(memcached_st *ptr, if (key_length == 0) return MEMCACHED_NO_KEY_PROVIDED; - /* Leaving this WATCHPOINT_ASSERT in since only a library fubar could blow this */ -#ifdef NOT_DONE - if (!(ptr->flags & MEM_NO_BLOCK) && ptr->write_buffer_offset != 0) - WATCHPOINT_ASSERT(0); -#endif - - if (ptr->hosts == NULL || ptr->number_of_hosts == 0) + if (ptr->number_of_hosts == 0) return MEMCACHED_NO_SERVERS; - - server_key= memcached_generate_hash(ptr, key, key_length); - - rc= memcached_connect(ptr, server_key); - if (rc != MEMCACHED_SUCCESS) - return rc; + server_key= memcached_generate_hash(ptr, key, key_length); if (cas) write_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, @@ -96,15 +85,9 @@ static inline memcached_return memcached_send(memcached_st *ptr, goto error; } - /* - We have to flush after sending the command. Memcached is not smart enough - to just keep reading from the socket :( - */ - if ((sent_length= memcached_io_write(ptr, server_key, buffer, write_length, 0)) == -1) - { - rc= MEMCACHED_WRITE_FAILURE; + rc= memcached_do(ptr, server_key, buffer, write_length, 0); + if (rc != MEMCACHED_SUCCESS) goto error; - } if ((sent_length= memcached_io_write(ptr, server_key, value, value_length, 0)) == -1) { @@ -119,12 +102,11 @@ static inline memcached_return memcached_send(memcached_st *ptr, if ((sent_length= memcached_io_write(ptr, server_key, "\r\n", 2, to_write)) == -1) { - memcached_quit_server(ptr, server_key); rc= MEMCACHED_WRITE_FAILURE; goto error; } - if ((ptr->flags & MEM_NO_BLOCK) && verb == SET_OP) + if (to_write == 0) { rc= MEMCACHED_SUCCESS; memcached_server_response_increment(ptr, server_key);