X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=lib%2Fmemcached_get.c;h=63a981e11ae13b9604ca7d948e8e2ad96b4c6c11;hb=6f50a6acc95303396a8a073c3746cdff83df2301;hp=201cfcdf82d62b9661f838fa7e2fba70e9422573;hpb=735295f0989edbd884a2c3935d1219a59ebe5698;p=awesomized%2Flibmemcached

diff --git a/lib/memcached_get.c b/lib/memcached_get.c
index 201cfcdf..63a981e1 100644
--- a/lib/memcached_get.c
+++ b/lib/memcached_get.c
@@ -1,284 +1,141 @@
 #include "common.h"
 #include "memcached_io.h"
 
-static char *memcached_value_fetch(memcached_st *ptr, char *key, size_t *key_length, 
-                                   size_t *value_length, 
-                                   uint16_t *flags,
-                                   memcached_return *error,
-                                   char load_key,
-                                   unsigned int server_key)
-{
-  char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
-  char *string_ptr;
-  char *end_ptr;
-
-  assert(value_length);
-  assert(flags);
-  assert(error);
-
-  memset(buffer, 0, MEMCACHED_DEFAULT_COMMAND_SIZE);
-  end_ptr= buffer + MEMCACHED_DEFAULT_COMMAND_SIZE;
-
-  *value_length= 0;
-
-  *error= memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key);
-
-  if (*error == MEMCACHED_SUCCESS)
-  {
-    char *next_ptr;
-
-    string_ptr= buffer;
-    string_ptr+= 6; /* "VALUE " */
-
-    /* We load the key */
-    if (load_key)
-    {
-      memset(key, 0, MEMCACHED_MAX_KEY);
-      *key_length= 0;
-
-      for (; end_ptr == string_ptr || *string_ptr != ' '; string_ptr++)
-      {
-        *key= *string_ptr;
-        key++;
-        (*key_length)++;
-      }
-    }
-    else /* Skip characters */
-      for (; end_ptr == string_ptr || *string_ptr != ' '; string_ptr++);
-
-    if (end_ptr == string_ptr)
-        goto read_error;
-
-    /* Flags fetch move past space */
-    string_ptr++;
-    if (end_ptr == string_ptr)
-        goto read_error;
-    for (next_ptr= string_ptr; end_ptr == string_ptr || *string_ptr != ' '; string_ptr++);
-    *flags= (uint16_t)strtol(next_ptr, &string_ptr, 10);
-
-    if (end_ptr == string_ptr)
-        goto read_error;
-
-    /* Length fetch move past space*/
-    string_ptr++;
-    if (end_ptr == string_ptr)
-        goto read_error;
-
-    for (next_ptr= string_ptr; end_ptr == string_ptr || *string_ptr != ' '; string_ptr++);
-    *value_length= (size_t)strtoll(next_ptr, &string_ptr, 10);
-
-    if (end_ptr == string_ptr)
-        goto read_error;
-
-    /* Skip past the \r\n */
-    string_ptr+= 2;
-
-    if (end_ptr < string_ptr)
-        goto read_error;
-
-    if (*value_length)
-    {
-      size_t read_length;
-      size_t to_read;
-      char *value;
-      char *value_ptr;
-
-      /* We add two bytes so that we can walk the \r\n */
-      value= (char *)malloc(((*value_length) +2) * sizeof(char));
-      memset(value, 0, ((*value_length) +2) * sizeof(char));
-
-      if (!value)
-      {
-        *value_length= 0;
-        *error= MEMCACHED_MEMORY_ALLOCATION_FAILURE;
-        return NULL;
-      }
-
-      value_ptr= value;
-      read_length= 0;
-      to_read= (*value_length) + 2;
-
-      read_length= memcached_io_read(ptr, server_key,
-                                     value_ptr, to_read);
-
-      if (read_length != (size_t)(*value_length + 2))
-      {
-        free(value);
-        goto read_error;
-      }
-
-      return value;
-    }
-  }
-  else if (*error == MEMCACHED_END)
-    *error= MEMCACHED_NOTFOUND;
-
-  return NULL;
-read_error:
-  *error= MEMCACHED_PARTIAL_READ;
-  return NULL;
-}
-
+/* 
+  What happens if no servers exist?
+*/
 char *memcached_get(memcached_st *ptr, char *key, size_t key_length, 
                     size_t *value_length, 
-                    uint16_t *flags,
+                    uint32_t *flags,
                     memcached_return *error)
 {
-  size_t send_length;
-  char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
-  unsigned int server_key;
-  char *value;
-  LIBMEMCACHED_MEMCACHED_GET_START();
-
-  *value_length= 0;
-  *error= memcached_connect(ptr);
+  return memcached_get_by_key(ptr, NULL, 0, key, key_length, value_length, 
+                              flags, error);
+}
 
-  if (*error != MEMCACHED_SUCCESS)
-    goto error;
+char *memcached_get_by_key(memcached_st *ptr, 
+                           char *master_key, size_t master_key_length, 
+                           char *key, size_t key_length, 
+                           size_t *value_length, 
+                           uint32_t *flags,
+                           memcached_return *error)
+{
+  char *value;
 
-  server_key= memcached_generate_hash(key, key_length) % ptr->number_of_hosts;
+  /* Request the key */
+  *error= memcached_mget_by_key(ptr, 
+                                master_key, 
+                                master_key_length, 
+                                &key, &key_length, 1);
 
-  send_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, "get %.*s\r\n", 
-                        (int)key_length, key);
+  value= memcached_fetch(ptr, NULL, NULL, 
+                         value_length, flags, error);
 
-  if ((memcached_io_write(ptr, server_key, buffer, send_length, 1)) == -1)
-  {
-    *error= MEMCACHED_WRITE_FAILURE;
-    goto error;
-  }
-
-  value= memcached_value_fetch(ptr, key, &key_length, value_length, flags,
-                               error, 0, server_key);
-  if (*error == MEMCACHED_END && *value_length == 0)
-  {
+  /* This is for historical reasons */
+  if (*error == MEMCACHED_END)
     *error= MEMCACHED_NOTFOUND;
-    goto error;
-  }
-  else if (*error == MEMCACHED_SUCCESS)
-  {
-    memcached_return rc;
-    /* We need to read END */
-    rc= memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key);
 
-    if (rc != MEMCACHED_END)
-    {
-      *error= MEMCACHED_PROTOCOL_ERROR;
-      goto error;
-    }
-  }
-  else 
-      goto error;
+  if (value == NULL)
+    return NULL;
 
-  LIBMEMCACHED_MEMCACHED_GET_END();
+  memcached_finish(ptr);
 
   return value;
-
-error:
-  free(value);
-  *value_length= 0;
-
-  LIBMEMCACHED_MEMCACHED_GET_END();
-
-    return NULL;
 }
 
 memcached_return memcached_mget(memcached_st *ptr, 
                                 char **keys, size_t *key_length, 
                                 unsigned int number_of_keys)
 {
-  char buffer[HUGE_STRING_LEN];
+  return memcached_mget_by_key(ptr, NULL, 0, keys, key_length, number_of_keys);
+}
+
+memcached_return memcached_mget_by_key(memcached_st *ptr, 
+                                       char *master_key, size_t master_key_length,
+                                       char **keys, size_t *key_length, 
+                                       unsigned int number_of_keys)
+{
   unsigned int x;
-  memcached_return rc;
-  memcached_string_st **cursor_key_exec;
-  LIBMEMCACHED_MEMCACHED_MGET_START();
+  memcached_return rc= MEMCACHED_NOTFOUND;
+  char *get_command= "get ";
+  uint8_t get_command_length= 4;
+  unsigned int master_server_key= 0;
 
+  LIBMEMCACHED_MEMCACHED_MGET_START();
   ptr->cursor_server= 0;
-  memset(buffer, 0, HUGE_STRING_LEN);
 
-  rc= memcached_connect(ptr);
+  if (number_of_keys == 0)
+    return MEMCACHED_NOTFOUND;
 
-  if (rc != MEMCACHED_SUCCESS)
-    return rc;
+  if (ptr->number_of_hosts == 0)
+    return MEMCACHED_NO_SERVERS;
 
-  cursor_key_exec= (memcached_string_st **)malloc(sizeof(memcached_string_st *) * ptr->number_of_hosts);
-  memset(cursor_key_exec, 0, sizeof(memcached_string_st *) * ptr->number_of_hosts);
+  if (ptr->flags & MEM_SUPPORT_CAS)
+  {
+    get_command= "gets ";
+    get_command_length= 5;
+  }
+
+  memcached_finish(ptr);
 
+  if (master_key && master_key_length)
+    master_server_key= memcached_generate_hash(ptr, master_key, master_key_length);
 
+  /* 
+    If a server fails we warn about errors and start all over with sending keys
+    to the server.
+  */
   for (x= 0; x < number_of_keys; x++)
   {
     unsigned int server_key;
 
-    server_key= memcached_generate_hash(keys[x], key_length[x]) % ptr->number_of_hosts;
+    if (master_server_key)
+      server_key= master_server_key;
+    else
+      server_key= memcached_generate_hash(ptr, keys[x], key_length[x]);
 
-    if (cursor_key_exec[server_key])
+    if (ptr->hosts[server_key].cursor_active == 0)
     {
-      memcached_string_st *string= cursor_key_exec[server_key];
+      rc= memcached_connect(ptr, server_key);
 
-      memcached_string_append_character(ptr, string, ' ');
-      memcached_string_append(ptr, string, keys[x], key_length[x]);
+      if ((memcached_io_write(ptr, server_key, get_command, get_command_length, 0)) == -1)
+      {
+        rc= MEMCACHED_SOME_ERRORS;
+        continue;
+      }
+      ptr->hosts[server_key].cursor_active= 1;
     }
-    else
-    {
-      memcached_string_st *string= memcached_string_create(ptr, SMALL_STRING_LEN);
-
-      /* We need to figure out the correct way to error in case of this failure */
-      if (!string)
-        assert(0);
 
-      memcached_string_append(ptr, string, "get ", 4);
-      memcached_string_append(ptr, string, keys[x], key_length[x]);
+    if ((memcached_io_write(ptr, server_key, keys[x], key_length[x], 0)) == -1)
+    {
+      ptr->hosts[server_key].cursor_active= 0;
+      rc= MEMCACHED_SOME_ERRORS;
+      continue;
+    }
 
-      cursor_key_exec[server_key]= string;
+    if ((memcached_io_write(ptr, server_key, " ", 1, 0)) == -1)
+    {
+      ptr->hosts[server_key].cursor_active= 0;
+      rc= MEMCACHED_SOME_ERRORS;
+      continue;
     }
   }
 
-
   /*
     Should we muddle on if some servers are dead?
   */
   for (x= 0; x < ptr->number_of_hosts; x++)
   {
-    if (cursor_key_exec[x])
+    if (ptr->hosts[x].cursor_active == 1)
     {
-      memcached_string_st *string= cursor_key_exec[x];
-      memcached_string_append(ptr, string, "\r\n", 2);
-
-      if ((memcached_io_write(ptr, x, string->string, 
-                              memcached_string_length(ptr, string), 1)) == -1)
+      /* We need to doo something about non-connnected hosts in the future */
+      if ((memcached_io_write(ptr, x, "\r\n", 2, 1)) == -1)
       {
-        memcached_quit(ptr);
         rc= MEMCACHED_SOME_ERRORS;
       }
-      memcached_string_free(ptr, string);
-      cursor_key_exec[x]= NULL; /* Remove warning */
     }
   }
 
-  free(cursor_key_exec);
-
   LIBMEMCACHED_MEMCACHED_MGET_END();
   return rc;
 }
-
-char *memcached_fetch(memcached_st *ptr, char *key, size_t *key_length, 
-                    size_t *value_length, 
-                    uint16_t *flags,
-                    memcached_return *error)
-{
-  char *value_check;
-
-  while (ptr->cursor_server < ptr->number_of_hosts)
-  {
-    value_check= memcached_value_fetch(ptr, key, key_length, value_length, flags,
-                                       error, 1, ptr->cursor_server);
-    
-    if (*error == MEMCACHED_NOTFOUND)
-      ptr->cursor_server++;
-    else if (*error != MEMCACHED_SUCCESS)
-      return NULL;
-    else
-      return value_check;
-  }
-
-  return NULL;
-}