X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=lib%2Fmemcached_connect.c;h=2120db5c7b4e3d3a5f5aa8bde378490bbf6c765f;hb=3529e69b4a637b6875d82cb22a250d8abc6e8e85;hp=a0c8737c31df48e6e6b7b98e5549d06344408e42;hpb=875200dc0c5668bba4f8a68b487f9d2f2a1eedb0;p=m6w6%2Flibmemcached

diff --git a/lib/memcached_connect.c b/lib/memcached_connect.c
index a0c8737c..2120db5c 100644
--- a/lib/memcached_connect.c
+++ b/lib/memcached_connect.c
@@ -1,25 +1,6 @@
-#include <memcached.h>
+#include "common.h"
 
-memcached_return memcached_server_add(memcached_st *ptr, char *hostname, unsigned int port)
-{
-  if (!port)
-    port= MEMCACHED_DEFAULT_PORT; 
-
-  if (!hostname)
-    hostname= "localhost"; 
-
-
-  ptr->hosts= (memcached_host_st *)realloc(ptr->hosts, sizeof(memcached_host_st) * (ptr->number_of_hosts+1));
-  ptr->hosts[ptr->number_of_hosts].hostname=
-    (char *)malloc(sizeof(char) * (strlen(hostname)+1));
-  memset(ptr->hosts[ptr->number_of_hosts].hostname, 0, strlen(hostname)+1);
-  memcpy(ptr->hosts[ptr->number_of_hosts].hostname, hostname, strlen(hostname));
-  ptr->hosts[ptr->number_of_hosts].port= port;
-  ptr->hosts[ptr->number_of_hosts].fd= -1;
-  ptr->number_of_hosts++;
-
-  return MEMCACHED_SUCCESS;
-}
+#include <fcntl.h>
 
 memcached_return memcached_connect(memcached_st *ptr)
 {
@@ -27,47 +8,52 @@ memcached_return memcached_connect(memcached_st *ptr)
   struct sockaddr_in localAddr, servAddr;
   struct hostent *h;
 
-  if (ptr->connected)
+  LIBMEMCACHED_MEMCACHED_CONNECT_START();
+
+  if (ptr->connected == ptr->number_of_hosts)
     return MEMCACHED_SUCCESS;
 
   if (!ptr->hosts)
-  {
-    memcached_return rc;
-    rc= memcached_server_add(ptr, NULL, 0);
-
-    if (rc != MEMCACHED_SUCCESS)
-      return rc;
-  }
-
+    return MEMCACHED_NO_SERVERS;
 
   for (x= 0; x < ptr->number_of_hosts; x++)
   {
-    if ((h= gethostbyname(ptr->hosts[x].hostname)) == NULL)
-      return MEMCACHED_HOST_LOCKUP_FAILURE;
-
-    servAddr.sin_family= h->h_addrtype;
-    memcpy((char *) &servAddr.sin_addr.s_addr, h->h_addr_list[0], h->h_length);
-    servAddr.sin_port = htons(ptr->hosts[x].port);
-
-    /* Create the socket */
-    if ((ptr->hosts[0].fd= socket(AF_INET, SOCK_STREAM, 0)) < 0)
-      return MEMCACHED_CONNECTION_SOCKET_CREATE_FAILURE;
-
-
-    /* bind any port number */
-    localAddr.sin_family = AF_INET;
-    localAddr.sin_addr.s_addr = htonl(INADDR_ANY);
-    localAddr.sin_port = htons(0);
-
-    if (bind(ptr->hosts[0].fd, (struct sockaddr *) &localAddr, sizeof(localAddr)) < 0)
-      return(MEMCACHED_CONNECTION_BIND_FAILURE);
-
-    /* connect to server */
-    if (connect(ptr->hosts[0].fd, (struct sockaddr *) &servAddr, sizeof(servAddr)) < 0)
-      return MEMCACHED_HOST_LOCKUP_FAILURE;
+    if (ptr->hosts[x].fd == -1)
+    {
+      int flags;
+      
+      if ((h= gethostbyname(ptr->hosts[x].hostname)) == NULL)
+        return MEMCACHED_HOST_LOCKUP_FAILURE;
+
+      servAddr.sin_family= h->h_addrtype;
+      memcpy((char *) &servAddr.sin_addr.s_addr, h->h_addr_list[0], h->h_length);
+      servAddr.sin_port = htons(ptr->hosts[x].port);
+
+      /* Create the socket */
+      if ((ptr->hosts[0].fd= socket(AF_INET, SOCK_STREAM, 0)) < 0)
+        return MEMCACHED_CONNECTION_SOCKET_CREATE_FAILURE;
+
+
+      /* bind any port number */
+      localAddr.sin_family = AF_INET;
+      localAddr.sin_addr.s_addr = htonl(INADDR_ANY);
+      localAddr.sin_port = htons(0);
+
+#ifdef NOT_YET
+      /* For the moment, not getting a nonblocking mode will note be fatal */
+      flags= fcntl(ptr->hosts[0].fd, F_GETFL, 0);
+      if (flags != -1)
+        (void)fcntl(ptr->hosts[0].fd, F_SETFL, flags | O_NONBLOCK);
+#endif
+
+      /* connect to server */
+      if (connect(ptr->hosts[0].fd, (struct sockaddr *) &servAddr, sizeof(servAddr)) < 0)
+        return MEMCACHED_HOST_LOCKUP_FAILURE;
+
+      ptr->connected++;
+    }
   }
-
-  ptr->connected= 1;
+  LIBMEMCACHED_MEMCACHED_CONNECT_END();
 
   return MEMCACHED_SUCCESS;
 }