X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=lib%2Fmemcached_auto.c;h=4af85e97bd385d56951aed7b192022482f23119b;hb=05a0de51880aa6ee2428a365ef5d6ad530f96454;hp=25f9aaf9efb7f44a5348a46fc2e12bc4d790762c;hpb=131622cdc2710ecd9ad554ce7d08c6003fbdcf6e;p=m6w6%2Flibmemcached diff --git a/lib/memcached_auto.c b/lib/memcached_auto.c index 25f9aaf9..4af85e97 100644 --- a/lib/memcached_auto.c +++ b/lib/memcached_auto.c @@ -4,56 +4,54 @@ static memcached_return memcached_auto(memcached_st *ptr, char *verb, char *key, size_t key_length, unsigned int offset, - unsigned int *value) + uint64_t *value) { - size_t send_length, sent_length; + size_t send_length; memcached_return rc; char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE]; unsigned int server_key; + if (key_length == 0) + return MEMCACHED_NO_KEY_PROVIDED; + if (ptr->hosts == NULL || ptr->number_of_hosts == 0) return MEMCACHED_NO_SERVERS; server_key= memcached_generate_hash(ptr, key, key_length); - if ((rc= memcached_connect(ptr, server_key)) != MEMCACHED_SUCCESS) - return rc; - send_length= snprintf(buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, "%s %.*s %u\r\n", verb, (int)key_length, key, offset); if (send_length >= MEMCACHED_DEFAULT_COMMAND_SIZE) return MEMCACHED_WRITE_FAILURE; - sent_length= memcached_io_write(ptr, server_key, buffer, send_length, 1); - if (sent_length == -1 || sent_length != send_length) - return MEMCACHED_WRITE_FAILURE; - - memset(buffer, 0, MEMCACHED_DEFAULT_COMMAND_SIZE); + rc= memcached_do(&ptr->hosts[server_key], buffer, send_length, 1); + if (rc != MEMCACHED_SUCCESS) + return rc; - rc= memcached_response(ptr, buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, server_key); + rc= memcached_response(&ptr->hosts[server_key], buffer, MEMCACHED_DEFAULT_COMMAND_SIZE, NULL); /* So why recheck responce? Because the protocol is brain dead :) The number returned might end up equaling one of the string - values. Less chance of a mistake with memcmp() so we will + values. Less chance of a mistake with strncmp() so we will use it. We still called memcached_response() though since it worked its magic for non-blocking IO. */ - if (!memcmp(buffer, "ERROR\r\n", MEMCACHED_DEFAULT_COMMAND_SIZE)) + if (!strncmp(buffer, "ERROR\r\n", 7)) { *value= 0; rc= MEMCACHED_PROTOCOL_ERROR; } - else if (!memcmp(buffer, "NOT_FOUND\r\n", MEMCACHED_DEFAULT_COMMAND_SIZE)) + else if (!strncmp(buffer, "NOT_FOUND\r\n", 11)) { *value= 0; rc= MEMCACHED_NOTFOUND; } else { - *value= strtol(buffer, (char **)NULL, 10); + *value= (uint64_t)strtoll(buffer, (char **)NULL, 10); rc= MEMCACHED_SUCCESS; } @@ -62,8 +60,8 @@ static memcached_return memcached_auto(memcached_st *ptr, memcached_return memcached_increment(memcached_st *ptr, char *key, size_t key_length, - unsigned int offset, - unsigned int *value) + uint32_t offset, + uint64_t *value) { memcached_return rc; @@ -76,8 +74,8 @@ memcached_return memcached_increment(memcached_st *ptr, memcached_return memcached_decrement(memcached_st *ptr, char *key, size_t key_length, - unsigned int offset, - unsigned int *value) + uint32_t offset, + uint64_t *value) { memcached_return rc;