X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=http_request_api.c;h=8c112497896f0ecc78fadf01bf3332c978ee5cb8;hb=76ef3c1710bd22c560f9459f00452050d72f44db;hp=84acf1c37b7eb97ac8781e459f82ccc55e2af534;hpb=7071b19ff84a668f6b9273a4dcf762a3cf7565f7;p=m6w6%2Fext-http

diff --git a/http_request_api.c b/http_request_api.c
index 84acf1c..8c11249 100644
--- a/http_request_api.c
+++ b/http_request_api.c
@@ -211,7 +211,7 @@ static curlioerr http_curl_ioctl_callback(CURL *, curliocmd, void *);
 /* }}} */
 
 /* {{{ CURL *http_curl_init(http_request *) */
-PHP_HTTP_API CURL * _http_curl_init_ex(CURL *ch, void *context, char *error_buffer)
+PHP_HTTP_API CURL * _http_curl_init_ex(CURL *ch, http_request *request)
 {
 	if (ch || (ch = curl_easy_init())) {
 #if defined(ZTS)
@@ -226,9 +226,18 @@ PHP_HTTP_API CURL * _http_curl_init_ex(CURL *ch, void *context, char *error_buff
 		HTTP_CURL_OPT_EX(ch, READFUNCTION, http_curl_read_callback);
 		HTTP_CURL_OPT_EX(ch, IOCTLFUNCTION, http_curl_ioctl_callback);
 		HTTP_CURL_OPT_EX(ch, WRITEFUNCTION, http_curl_dummy_callback);
-		HTTP_CURL_OPT_EX(ch, DEBUGDATA, context);
-		HTTP_CURL_OPT_EX(ch, PRIVATE, context);
-		HTTP_CURL_OPT_EX(ch, ERRORBUFFER, error_buffer);
+		
+		/* set context */
+		if (request) {
+			HTTP_CURL_OPT_EX(ch, PRIVATE, request);
+			HTTP_CURL_OPT_EX(ch, DEBUGDATA, request);
+			HTTP_CURL_OPT_EX(ch, ERRORBUFFER, request->_error);
+			
+			/* attach curl handle */
+			request->ch = ch;
+			/* set defaults (also in http_request_reset()) */
+			http_request_defaults(request);
+		}
 	}
 	
 	return ch;
@@ -414,7 +423,6 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
 	TSRMLS_FETCH_FROM_CTX(request->tsrm_ls);
 	
 	HTTP_CHECK_CURL_INIT(request->ch, http_curl_init(request), return FAILURE);
-	http_request_defaults(request);
 	
 	/* set options */
 	HTTP_CURL_OPT(URL, request->url);
@@ -477,8 +485,13 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
 	}
 
 	/* useragent, default "PECL::HTTP/version (PHP/version)" */
-	if ((zoption = http_request_option(request, options, "useragent", IS_STRING)) && Z_STRLEN_P(zoption)) {
-		HTTP_CURL_OPT(USERAGENT, Z_STRVAL_P(zoption));
+	if ((zoption = http_request_option(request, options, "useragent", IS_STRING))) {
+		/* allow to send no user agent, not even default one */
+		if (Z_STRLEN_P(zoption)) {
+			HTTP_CURL_OPT(USERAGENT, Z_STRVAL_P(zoption));
+		} else {
+			HTTP_CURL_OPT(USERAGENT, NULL);
+		}
 	}
 
 	/* additional headers, array('name' => 'value') */
@@ -629,22 +642,38 @@ PHP_HTTP_API STATUS _http_request_prepare(http_request *request, HashTable *opti
 	switch (request->meth)
 	{
 		case HTTP_GET:
+			HTTP_CURL_OPT(NOBODY, 0);
+			HTTP_CURL_OPT(POST, 0);
+			HTTP_CURL_OPT(UPLOAD, 0);
 			HTTP_CURL_OPT(HTTPGET, 1);
 		break;
 
 		case HTTP_HEAD:
+			HTTP_CURL_OPT(POST, 0);
+			HTTP_CURL_OPT(UPLOAD, 0);
+			HTTP_CURL_OPT(HTTPGET, 0);
 			HTTP_CURL_OPT(NOBODY, 1);
 		break;
 
 		case HTTP_POST:
+			HTTP_CURL_OPT(UPLOAD, 0);
+			HTTP_CURL_OPT(HTTPGET, 0);
+			HTTP_CURL_OPT(NOBODY, 0);
 			HTTP_CURL_OPT(POST, 1);
 		break;
 
 		case HTTP_PUT:
+			HTTP_CURL_OPT(HTTPGET, 0);
+			HTTP_CURL_OPT(NOBODY, 0);
+			HTTP_CURL_OPT(POST, 0);
 			HTTP_CURL_OPT(UPLOAD, 1);
 		break;
 
 		default:
+			HTTP_CURL_OPT(HTTPGET, 0);
+			HTTP_CURL_OPT(NOBODY, 0);
+			HTTP_CURL_OPT(POST, 0);
+			HTTP_CURL_OPT(UPLOAD, 0);
 			if (http_request_method_exists(0, request->meth, NULL)) {
 				HTTP_CURL_OPT(CUSTOMREQUEST, http_request_method_name(request->meth));
 			} else {