X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=http_message_api.c;h=01aa0e316110c56f47b403538ffdbb91fb4fe925;hb=9d2250ea30eb8d9905eef2e28b82e8559e237aa2;hp=ac056ad7e4cc437c8f0b1fc674c2ceb736cb902c;hpb=419ba9235752d56f15b393fc7969316978c6c721;p=m6w6%2Fext-http diff --git a/http_message_api.c b/http_message_api.c index ac056ad..01aa0e3 100644 --- a/http_message_api.c +++ b/http_message_api.c @@ -131,6 +131,7 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char zend_bool free_msg = msg ? 0 : 1; if ((!message) || (message_length < HTTP_MSG_MIN_SIZE)) { + http_error_ex(HE_WARNING, HTTP_E_INVALID_PARAM, "Empty or too short HTTP message: '%s'", message); return NULL; } @@ -140,9 +141,10 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char if (free_msg) { http_message_free(&msg); } + http_error(HE_WARNING, HTTP_E_MALFORMED_HEADERS, "Failed to parse message headers"); return NULL; } - + /* header parsing stops at (CR)LF (CR)LF */ if ((body = http_locate_body(message))) { zval *c; @@ -164,6 +166,8 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char MAKE_STD_ZVAL(len); ZVAL_STRINGL(len, tmp, tmp_len, 0); + ZVAL_ADDREF(c); + zend_hash_add(&msg->hdrs, "X-Original-Transfer-Encoding", sizeof("X-Original-Transfer-Encoding"), (void *) &c, sizeof(zval *), NULL); zend_hash_del(&msg->hdrs, "Transfer-Encoding", sizeof("Transfer-Encoding")); zend_hash_del(&msg->hdrs, "Content-Length", sizeof("Content-Length")); zend_hash_add(&msg->hdrs, "Content-Length", sizeof("Content-Length"), (void *) &len, sizeof(zval *), NULL); @@ -227,16 +231,17 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char if (http_message_header(msg, "Vary") && (c = http_message_header(msg, "Content-Encoding"))) { char *decoded = NULL; size_t decoded_len = 0; -# if defined(HAVE_ZLIB) && !defined(HTTP_HAVE_ZLIB) +# if !defined(HTTP_HAVE_ZLIB) zval func, retval, arg, *args[1]; INIT_PZVAL(&func); INIT_PZVAL(&retval); INIT_PZVAL(&arg); - ZVAL_STRINGL(&func, "gzinflate", lenof("gzinflate"), 0); args[0] = &arg; -# endif /* HAVE_ZLIB && !HTTP_HAVE_ZLIB */ +# endif /* !HTTP_HAVE_ZLIB */ -# define DECODE_WITH_EXT_ZLIB() \ +# define DECODE_WITH_EXT_ZLIB(function, S, L) \ + ZVAL_STRINGL(&func, function, lenof(function), 0); \ + ZVAL_STRINGL(&arg, (S), (L), 0); \ if (SUCCESS == call_user_function(EG(function_table), NULL, &func, &retval, 1, args TSRMLS_CC)) { \ if (Z_TYPE(retval) == IS_STRING) { \ decoded = Z_STRVAL(retval); \ @@ -244,28 +249,24 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char } \ } -# define REMEMBER_ENCODING() \ - if (decoded) { \ - ZVAL_ADDREF(c); \ - zend_hash_add(&msg->hdrs, "X-Original-Content-Encoding", sizeof("X-Original-Content-Encoding"), (void *) &c, sizeof(zval *), NULL); \ - } - if (!strcasecmp(Z_STRVAL_P(c), "gzip") || !strcasecmp(Z_STRVAL_P(c), "x-gzip")) { # ifdef HTTP_HAVE_ZLIB http_encoding_gzdecode(PHPSTR_VAL(msg), PHPSTR_LEN(msg), &decoded, &decoded_len); # else - ZVAL_STRINGL(&arg, PHPSTR_VAL(msg) + 10, PHPSTR_LEN(msg) - 18, 0); - DECODE_WITH_EXT_ZLIB(); + DECODE_WITH_EXT_ZLIB("gzinflate", PHPSTR_VAL(msg) + 10, PHPSTR_LEN(msg) - 18); # endif /* HTTP_HAVE_ZLIB */ - REMEMBER_ENCODING(); } else if (!strcasecmp(Z_STRVAL_P(c), "deflate")) { # ifdef HTTP_HAVE_ZLIB http_encoding_inflate(PHPSTR_VAL(msg), PHPSTR_LEN(msg), &decoded, &decoded_len); # else - ZVAL_STRINGL(&arg, PHPSTR_VAL(msg), PHPSTR_LEN(msg), 0); - DECODE_WITH_EXT_ZLIB(); + DECODE_WITH_EXT_ZLIB("gzinflate", PHPSTR_VAL(msg), PHPSTR_LEN(msg)); +# endif /* HTTP_HAVE_ZLIB */ + } else if (!strcasecmp(Z_STRVAL_P(c), "compress") || !strcasecmp(Z_STRVAL_P(c), "x-compress")) { +# ifdef HTTP_HAVE_ZLIB + http_encoding_uncompress(PHPSTR_VAL(msg), PHPSTR_LEN(msg), &decoded, &decoded_len); +# else + DECODE_WITH_EXT_ZLIB("gzuncompress", PHPSTR_VAL(msg), PHPSTR_LEN(msg)); # endif /* HTTP_HAVE_ZLIB */ - REMEMBER_ENCODING(); } if (decoded) { @@ -277,8 +278,10 @@ PHP_HTTP_API http_message *_http_message_parse_ex(http_message *msg, const char MAKE_STD_ZVAL(len); ZVAL_STRINGL(len, tmp, tmp_len, 0); + ZVAL_ADDREF(c); + zend_hash_add(&msg->hdrs, "X-Original-Content-Encoding", sizeof("X-Original-Content-Encoding"), (void *) &c, sizeof(zval *), NULL); zend_hash_del(&msg->hdrs, "Content-Encoding", sizeof("Content-Encoding")); - if (zend_hash_find(&msg->hdrs, "Content-Length", sizeof("Content-Length"), (void **) &original_len) == SUCCESS) { + if (SUCCESS == zend_hash_find(&msg->hdrs, "Content-Length", sizeof("Content-Length"), (void **) &original_len)) { ZVAL_ADDREF(*original_len); zend_hash_add(&msg->hdrs, "X-Original-Content-Length", sizeof("X-Original-Content-Length"), (void *) original_len, sizeof(zval *), NULL); zend_hash_update(&msg->hdrs, "Content-Length", sizeof("Content-Length"), (void *) &len, sizeof(zval *), NULL); @@ -494,6 +497,7 @@ PHP_HTTP_API STATUS _http_message_send(http_message *message TSRMLS_DC) { #ifdef HTTP_HAVE_CURL char *uri = NULL; + http_request request; zval **zhost, options, headers; INIT_PZVAL(&options); @@ -524,21 +528,21 @@ PHP_HTTP_API STATUS _http_message_send(http_message *message TSRMLS_DC) uri = http_absolute_uri(message->http.info.request.URI); } - if (!strcasecmp("POST", message->http.info.request.method)) { + if ((request.meth = http_request_method_exists(1, 0, message->http.info.request.method))) { http_request_body body = {HTTP_REQUEST_BODY_CSTRING, PHPSTR_VAL(message), PHPSTR_LEN(message)}; - rs = http_post(uri, &body, Z_ARRVAL(options), NULL, NULL); - } else - if (!strcasecmp("GET", message->http.info.request.method)) { - rs = http_get(uri, Z_ARRVAL(options), NULL, NULL); - } else - if (!strcasecmp("HEAD", message->http.info.request.method)) { - rs = http_head(uri, Z_ARRVAL(options), NULL, NULL); + + http_request_init_ex(&request, NULL, request.meth, uri); + request.body = &body; + if (SUCCESS == (rs = http_request_prepare(&request, NULL))) { + http_request_exec(&request); + } + request.body = NULL; + http_request_dtor(&request); } else { http_error_ex(HE_WARNING, HTTP_E_REQUEST_METHOD, "Cannot send HttpMessage. Request method %s not supported", message->http.info.request.method); } - efree(uri); #else http_error(HE_WARNING, HTTP_E_RUNTIME, "HTTP requests not supported - ext/http was not linked against libcurl.");