X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;f=app%2FController%2FGithub%2FCallback.php;h=2347d0e67069ca946dbea6c924af10e59b312f06;hb=96da0fd4e37ae211394415d381413514edece6c7;hp=e6429fcf7de18f57ef2b313fa2247224b75b7cc4;hpb=9815b77a14832685f90d34f9a348af1cadd63576;p=pharext%2Fpharext.org

diff --git a/app/Controller/Github/Callback.php b/app/Controller/Github/Callback.php
index e6429fc..2347d0e 100644
--- a/app/Controller/Github/Callback.php
+++ b/app/Controller/Github/Callback.php
@@ -23,44 +23,51 @@ class Callback extends Github
 	
 	function __invoke(array $args = null) {
 		if ($this->app->getRequest()->getQuery("error")) {
-			$this->app->getView()->addData([
-				"error" => $this->app->getRequest()->getQuery("error_description")
-			]);
+			$this->app->getView()->addData($this->app->getRequest()->getQuery()->toArray());
 		} else {
-			$this->github->fetchToken(
-				$this->app->getRequest()->getQuery("code"),
-				$this->app->getRequest()->getQuery("state"),
-				function($token) {
-					$this->github->setToken($token->access_token);
-					$this->github->readAuthUser($this->createUserCallback($token));
-			})->send();
+			$this->validateUser();
+			
 			if (isset($this->session->returnto)) {
 				$returnto = $this->session->returnto;
 				unset($this->session->returnto);
 				$this->app->redirect($returnto);
 			} else {
 				$this->app->redirect(
-					$this->app->getBaseUrl()->mod("./github"));
+					$this->app->getBaseUrl()->mod(":./github"));
 			}
 		}
 		$this->app->display("github/callback");
 	}
 	
-	function createUserCallback($oauth) {
-		return function($user) use($oauth) {
-			$tx = $this->accounts->getConnection()->startTransaction();
+	private function validateUser() {
+		$this->github->fetchToken(
+			$this->app->getRequest()->getQuery("code"),
+			$this->app->getRequest()->getQuery("state")
+		)->then(function($result) use (&$oauth) {
+			list($oauth) = $result;
+			$this->github->setToken($oauth->access_token);
+			return $this->github->readAuthUser();
+		})->done(function($result) use(&$oauth) {
+			list($user) = $result;
+			$this->login(...$this->persistUser($oauth, $user));
+		});
 
-			if (($cookie = $this->app->getRequest()->getCookie("account"))) {
-				$account = $this->accounts->find(["account=" => $cookie])->current();
-			} elseif (!($account = $this->accounts->byOAuth("github", $oauth->access_token, $user->login))) {
-				$account = $this->accounts->createOAuthAccount("github", $oauth->access_token, $user->login);
-			}
-			$token = $account->updateToken("github", $oauth->access_token, $oauth);
-			$owner = $account->updateOwner("github", $user->login, $user);
-			
-			$tx->commit();
-			
-			$this->login($account, $token, $owner);
-		};
+		$this->github->drain();
+	}
+	
+	private function persistUser($oauth, $user) {
+		$tx = $this->accounts->getConnection()->startTransaction();
+
+		if (($cookie = $this->app->getRequest()->getCookie("account"))) {
+			$account = $this->accounts->find(["account=" => $cookie])->current();
+		} elseif (!($account = $this->accounts->byOAuth("github", $oauth->access_token, $user->login))) {
+			$account = $this->accounts->createOAuthAccount("github", $oauth->access_token, $user->login);
+		}
+		$token = $account->updateToken("github", $oauth->access_token, $oauth);
+		$owner = $account->updateOwner("github", $user->login, $user);
+
+		$tx->commit();
+
+		return [$account, $token, $owner];
 	}
 }