X-Git-Url: https://git.m6w6.name/?a=blobdiff_plain;ds=sidebyside;f=libmemcached%2Ftouch.cc;h=a1e6d0a18f219b6a007fe5f0dcc1e18bf4a68b36;hb=a6522efa221a7f60181159642c2d52d71cd2b88d;hp=1f793c5535bbb4854a49bc50c9e22f8c1c0a6b51;hpb=d9db3f534bc38ea22e83e5529ff93aea4150ab19;p=awesomized%2Flibmemcached diff --git a/libmemcached/touch.cc b/libmemcached/touch.cc index 1f793c55..a1e6d0a1 100644 --- a/libmemcached/touch.cc +++ b/libmemcached/touch.cc @@ -44,7 +44,7 @@ static memcached_return_t ascii_touch(memcached_instance_st* instance, { char expiration_buffer[MEMCACHED_MAXIMUM_INTEGER_DISPLAY_LENGTH +1]; int expiration_buffer_length= snprintf(expiration_buffer, sizeof(expiration_buffer), " %llu", (unsigned long long)expiration); - if (size_t(expiration_buffer_length) >= sizeof(expiration_buffer) or expiration_buffer_length < 0) + if (size_t(expiration_buffer_length) >= sizeof(expiration_buffer)+1 or expiration_buffer_length < 0) { return memcached_set_error(*instance, MEMCACHED_MEMORY_ALLOCATION_FAILURE, MEMCACHED_AT, memcached_literal_param("snprintf(MEMCACHED_MAXIMUM_INTEGER_DISPLAY_LENGTH)")); @@ -63,7 +63,6 @@ static memcached_return_t ascii_touch(memcached_instance_st* instance, memcached_return_t rc; if (memcached_failed(rc= memcached_vdo(instance, vector, 6, true))) { - memcached_io_reset(instance); return memcached_set_error(*instance, MEMCACHED_WRITE_FAILURE, MEMCACHED_AT); } @@ -96,7 +95,6 @@ static memcached_return_t binary_touch(memcached_instance_st* instance, memcached_return_t rc; if (memcached_failed(rc= memcached_vdo(instance, vector, 4, true))) { - memcached_io_reset(instance); return memcached_set_error(*instance, MEMCACHED_WRITE_FAILURE, MEMCACHED_AT); } @@ -124,9 +122,9 @@ memcached_return_t memcached_touch_by_key(memcached_st *shell, return rc; } - if (memcached_failed(rc= memcached_validate_key_length(key_length, ptr->flags.binary_protocol))) + if (memcached_failed(rc= memcached_key_test(*ptr, (const char **)&key, &key_length, 1))) { - return rc; + return memcached_set_error(*ptr, rc, MEMCACHED_AT); } uint32_t server_key= memcached_generate_hash_with_redistribution(ptr, group_key, group_key_length);