hints.ai_socktype = SOCK_STREAM;
int error = getaddrinfo(hostname, port, &hints, &ai);
- if (error != 0) {
+ if (error) {
if (error != EAI_SYSTEM) {
fprintf(stderr, "getaddrinfo(): %s\n", gai_strerror(error));
} else {
static memcached_socket_t connect_server(const char *hostname, const char *port) {
struct addrinfo *ai = lookuphost(hostname, port);
sock = INVALID_SOCKET;
- if (ai != NULL) {
+ if (ai) {
if ((sock = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol)) != INVALID_SOCKET) {
if (connect(sock, ai->ai_addr, ai->ai_addrlen) == SOCKET_ERROR) {
fprintf(stderr, "Failed to connect socket: %s\n", strerror(get_socket_errno()));
off_t key_offset = sizeof(protocol_binary_request_no_extras) + 8;
memcpy(cmd->bytes + key_offset, key, keylen);
- if (dta != NULL)
+ if (dta)
memcpy(cmd->bytes + key_offset + keylen, dta, dtalen);
}
off_t key_offset = sizeof(protocol_binary_request_no_extras);
- if (key != NULL)
+ if (key)
memcpy(cmd->bytes + key_offset, key, keylen);
- if (dta != NULL)
+ if (dta)
memcpy(cmd->bytes + key_offset + keylen, dta, dtalen);
}
cmd->flush.message.header.request.opcode = cc;
cmd->flush.message.header.request.opaque = 0xdeadbeef;
- if (exptime != 0 || use_extra) {
+ if (exptime || use_extra) {
cmd->flush.message.header.request.extlen = 4;
cmd->flush.message.body.expiration = htonl(exptime);
cmd->flush.message.header.request.bodylen = 4;
verify(rsp->plain.message.header.response.keylen == 0);
verify(rsp->plain.message.header.response.extlen == 0);
verify(rsp->plain.message.header.response.bodylen == 0);
- verify(rsp->plain.message.header.response.cas != 0);
+ verify(rsp->plain.message.header.response.cas);
break;
case PROTOCOL_BINARY_CMD_FLUSH:
case PROTOCOL_BINARY_CMD_NOOP:
verify(rsp->plain.message.header.response.keylen == 0);
verify(rsp->plain.message.header.response.extlen == 0);
verify(rsp->plain.message.header.response.bodylen == 8);
- verify(rsp->plain.message.header.response.cas != 0);
+ verify(rsp->plain.message.header.response.cas);
break;
case PROTOCOL_BINARY_CMD_STAT:
case PROTOCOL_BINARY_CMD_VERSION:
verify(rsp->plain.message.header.response.keylen == 0);
verify(rsp->plain.message.header.response.extlen == 0);
- verify(rsp->plain.message.header.response.bodylen != 0);
+ verify(rsp->plain.message.header.response.bodylen);
verify(rsp->plain.message.header.response.cas == 0);
break;
case PROTOCOL_BINARY_CMD_GETQ:
verify(rsp->plain.message.header.response.keylen == 0);
verify(rsp->plain.message.header.response.extlen == 4);
- verify(rsp->plain.message.header.response.cas != 0);
+ verify(rsp->plain.message.header.response.cas);
break;
case PROTOCOL_BINARY_CMD_GETK:
case PROTOCOL_BINARY_CMD_GETKQ:
- verify(rsp->plain.message.header.response.keylen != 0);
+ verify(rsp->plain.message.header.response.keylen);
verify(rsp->plain.message.header.response.extlen == 4);
- verify(rsp->plain.message.header.response.cas != 0);
+ verify(rsp->plain.message.header.response.cas);
break;
default:
execute(recv_packet(&rsp));
verify(
validate_response_header(&rsp, PROTOCOL_BINARY_CMD_STAT, PROTOCOL_BINARY_RESPONSE_SUCCESS));
- } while (rsp.plain.message.header.response.keylen != 0);
+ } while (rsp.plain.message.header.response.keylen);
return TEST_PASS;
}
static enum test_return receive_response(const char *msg) {
char buffer[80];
execute(receive_line(buffer, sizeof(buffer)));
- if (strcmp(msg, buffer) != 0) {
+ if (strcmp(msg, buffer)) {
fprintf(stderr, "[%s]\n", buffer);
}
verify(strcmp(msg, buffer) == 0);
execute(receive_line(buffer, sizeof(buffer)));
verify(strncmp(buffer, "VALUE ", 6) == 0);
char *end = strchr(buffer + 6, ' ');
- verify(end != NULL);
+ verify(end);
if (end) {
*end = '\0';
}
*key = strdup(buffer + 6);
- verify(*key != NULL);
+ verify(*key);
char *ptr = end + 1;
errno = 0;
verify(errno == 0);
verify(ptr != end);
verify(val == 0);
- verify(end != NULL);
+ verify(end);
errno = 0;
*ndata = (ssize_t) strtoul(end, &end, 10); /* size */
verify(errno == 0);
verify(ptr != end);
- verify(end != NULL);
+ verify(end);
while (end and *end != '\n' and isspace(*end)) ++end;
verify(end and *end == '\n');
*value = static_cast<char *>(malloc((size_t) *ndata));
- verify(*value != NULL);
+ verify(*value);
execute(retry_read(*value, (size_t) *ndata));
verify(errno == 0);
verify(ptr != end);
verify(val == 0);
- verify(end != NULL);
+ verify(end);
errno = 0;
val = strtoul(end, &end, 10); /* size */
verify(errno == 0);
verify(ptr != end);
verify(val == datasize);
- verify(end != NULL);
+ verify(end);
while (end and *end != '\n' and isspace(*end)) {
++end;
}
static enum test_return ascii_get_item(const char *key, const char *value, bool exist) {
char buffer[1024];
size_t datasize = 0;
- if (value != NULL) {
+ if (value) {
datasize = strlen(value);
}
verify(errno == 0);
verify(ptr != end);
verify(val == 0);
- verify(end != NULL);
+ verify(end);
errno = 0;
val = strtoul(end, &end, 10); /* size */
verify(errno == 0);
verify(ptr != end);
verify(val == datasize);
- verify(end != NULL);
+ verify(end);
errno = 0;
*cas = strtoul(end, &end, 10); /* cas */
verify(errno == 0);
verify(ptr != end);
verify(val == datasize);
- verify(end != NULL);
+ verify(end);
while (end and *end != '\n' and isspace(*end)) {
++end;
unsigned long *cas) {
char buffer[1024];
size_t datasize = 0;
- if (value != NULL) {
+ if (value) {
datasize = strlen(value);
}
char buffer[1024];
do {
execute(receive_line(buffer, sizeof(buffer)));
- } while (strcmp(buffer, "END\r\n") != 0);
+ } while (strcmp(buffer, "END\r\n"));
return TEST_PASS_RECONNECT;
}
return EXIT_FAILURE;
}
- for (int ii = 0; testcases[ii].description != NULL; ++ii) {
- if (testname != NULL && strcmp(testcases[ii].description, testname) != 0) {
+ for (int ii = 0; testcases[ii].description; ++ii) {
+ if (testname && strcmp(testcases[ii].description, testname)) {
continue;
}
if (prompt) {
fprintf(stdout, "\nPress <return> when you are ready? ");
char buffer[80] = {0};
- if (fgets(buffer, sizeof(buffer), stdin) != NULL) {
+ if (fgets(buffer, sizeof(buffer), stdin)) {
if (strncmp(buffer, "skip", 4) == 0) {
fprintf(stdout, "%-40s%s\n", testcases[ii].description, status_msg[TEST_SKIP]);
fflush(stdout);